From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932672AbdJYKXV (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Oct 2017 06:23:21 -0400
Received: from mx2.suse.de ([195.135.220.15]:53602 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932588AbdJYKXS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Oct 2017 06:23:18 -0400
Date: Wed, 25 Oct 2017 12:23:17 +0200
Message-ID: <s5hmv4fo7ai.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Kees Cook <keescook@chromium.org>
Cc: Jaroslav Kysela <perex@perex.cz>, David Howells <dhowells@redhat.com>,
        moderated for non-subscribers <alsa-devel@alsa-project.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: oss: waveartist: Convert timers to use timer_setup()
In-Reply-To: <CAGXu5j+eGu3gi6yhsZ7FbEK5CKvf_UAthzutaa4k+qB4bJ1Ppw@mail.gmail.com>
References: <20171024153521.GA112921@beast>
        <s5hshe8pcub.wl-tiwai@suse.de>
        <CAGXu5jLBDjeNs=yP76yhLvZXd2v3hH66K1QuMp5+LkCrQ+pW8w@mail.gmail.com>
        <s5hpo9bo837.wl-tiwai@suse.de>
        <CAGXu5j+eGu3gi6yhsZ7FbEK5CKvf_UAthzutaa4k+qB4bJ1Ppw@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 25 Oct 2017 12:17:25 +0200,
Kees Cook wrote:
> 
> On Wed, Oct 25, 2017 at 3:06 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Tue, 24 Oct 2017 22:07:34 +0200,
> > Kees Cook wrote:
> >>
> >> On Tue, Oct 24, 2017 at 12:25 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > On Tue, 24 Oct 2017 17:35:21 +0200,
> >> > Kees Cook wrote:
> >> >>
> >> >> In preparation for unconditionally passing the struct timer_list pointer to
> >> >> all timer callbacks, switch to using the new timer_setup() and from_timer()
> >> >> to pass the timer pointer explicitly.
> >> >>
> >> >> Cc: Jaroslav Kysela <perex@perex.cz>
> >> >> Cc: Takashi Iwai <tiwai@suse.com>
> >> >> Cc: David Howells <dhowells@redhat.com>
> >> >> Cc: alsa-devel@alsa-project.org
> >> >> Signed-off-by: Kees Cook <keescook@chromium.org>
> >> >
> >> > I'll skip this as sound/oss/* is already disabled in recent kernels in
> >> > kbuild, and we're going to remove the whole code soon later.
> >>
> >> At the end of these conversions, the old init_timer() and
> >> setup_timer() APIs will be removed, which would break anything still
> >> trying to use it (obviously). But if sound/oss/* is _already_
> >> unbuildable, then sure, this is fine by me to leave out. :)
> >
> > I see a few still remaining users of setup_timer() in sound/*.
> > Do you already have conversion patches?  They are all trivial, so I
> > can cook up in minutes, too.
> 
> I haven't sent the trivial ones (since I am expecting to do a treewide
> mechanical change for those). I can send you the rest as a patch
> instead, if you want?

Yeah, sure, earlier is easier for me :)


Takashi