From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B7B0C4338F for ; Wed, 18 Aug 2021 05:51:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63F086108B for ; Wed, 18 Aug 2021 05:51:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237946AbhHRFw2 (ORCPT ); Wed, 18 Aug 2021 01:52:28 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:51590 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237912AbhHRFw1 (ORCPT ); Wed, 18 Aug 2021 01:52:27 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 3DA581FF84; Wed, 18 Aug 2021 05:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1629265912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gOBc9QdWJpbD5fpGkPq549vmg28skbux9e9YpodQJTk=; b=qzAdBGy5rYkTSAlLyP4u4NM16KcDyZe2pS/M4qdRjm95dVo1gZXfcFcenf+4CMBtN4OQ7M BirLcIzri6rhp/lWqaKok0Xm5uTddGhr7u+61+lKuU/mcYVwuurDvNhIafSESReMU8qH88 sYWdqVpTq3TlNiyVShw4gtRTMFD855M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1629265912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gOBc9QdWJpbD5fpGkPq549vmg28skbux9e9YpodQJTk=; b=rPqTmXMsZtZur8zJB+j40Z0K0F5HPKvext8Hzc0g/DGEEYOiGipIzbdE+ZMDwx+M+KNlHB aE2qSV6Og6mJioCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 30BD2A3B91; Wed, 18 Aug 2021 05:51:52 +0000 (UTC) Date: Wed, 18 Aug 2021 07:51:52 +0200 Message-ID: From: Takashi Iwai To: Nathan Chancellor Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: hda/analog - Sink ad198x_shutup() and shuffle CONFIG_PM guards In-Reply-To: <20210818012705.311963-2-nathan@kernel.org> References: <20210818012705.311963-1-nathan@kernel.org> <20210818012705.311963-2-nathan@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Aug 2021 03:27:05 +0200, Nathan Chancellor wrote: > > When CONFIG_PM is not set, there is an unused function warning: > > sound/pci/hda/patch_analog.c:115:13: warning: unused function > 'ad198x_shutup' [-Wunused-function] > static void ad198x_shutup(struct hda_codec *codec) > ^ > 1 warning generated. > > Sink ad198x_shutup() into ad198x_suspend(), as it is only called in that > one space. Move the CONFIG_PM guards above ad198x_power_eapd_write() as > it is only called in ad198x_power_eapd(), which is in turn only called > in ad198x_power_eapd(). Those two functions are large enough that they > are left alone. > > Fixes: 327b34f2a97d ("ALSA: hda: Nuke unused reboot_notify callback") > Signed-off-by: Nathan Chancellor > --- Thanks, applied. Takashi