From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752189AbeEQG0T (ORCPT <rfc822;w@1wt.eu>);
        Thu, 17 May 2018 02:26:19 -0400
Received: from mx2.suse.de ([195.135.220.15]:56781 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750938AbeEQG0R (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 17 May 2018 02:26:17 -0400
Date: Thu, 17 May 2018 08:26:16 +0200
Message-ID: <s5ho9he94s7.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: Oleksandr Andrushchenko <andr2000@gmail.com>,
        alsa-devel@alsa-project.org, xen-devel@lists.xenproject.org,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, perex@perex.cz,
        Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] ALSA: xen-front: Implement handling of shared buffers
In-Reply-To: <19a2c003-6730-265a-29aa-1eedd37147b9@epam.com>
References: <20180514062742.25879-1-andr2000@gmail.com>
        <20180514062742.25879-5-andr2000@gmail.com>
        <s5ho9hi56ds.wl-tiwai@suse.de>
        <e37b5170-4fab-0c06-8902-730e57118ceb@gmail.com>
        <s5h8t8l5ufq.wl-tiwai@suse.de>
        <19a2c003-6730-265a-29aa-1eedd37147b9@epam.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 15 May 2018 08:02:08 +0200,
Oleksandr Andrushchenko wrote:
> 
> On 05/15/2018 09:01 AM, Takashi Iwai wrote:
> > On Tue, 15 May 2018 07:46:38 +0200,
> > Oleksandr Andrushchenko wrote:
> >> On 05/14/2018 11:28 PM, Takashi Iwai wrote:
> >>> On Mon, 14 May 2018 08:27:40 +0200,
> >>> Oleksandr Andrushchenko wrote:
> >>>> --- /dev/null
> >>>> +++ b/sound/xen/xen_snd_front_shbuf.c
> >>>> @@ -0,0 +1,193 @@
> >>>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
> >>>> +
> >>>> +/*
> >>>> + * Xen para-virtual sound device
> >>>> + *
> >>>> + * Copyright (C) 2016-2018 EPAM Systems Inc.
> >>>> + *
> >>>> + * Author: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>> + */
> >>>> +
> >>>> +#include <xen/xen.h>
> >>>> +#include <xen/xenbus.h>
> >>>> +
> >>>> +#include "xen_snd_front_shbuf.h"
> >>> Hm, with the local build test, I get the following error:
> >>>
> >>>     CC [M]  sound/xen/xen_snd_front_shbuf.o
> >>>     In file included from sound/xen/xen_snd_front_shbuf.c:11:0:
> >>>     ./include/xen/xen.h:18:8: error: unknown type name ‘bool’
> >>>      extern bool xen_pvh;
> >>>              ^~~~
> >>>      In file included from ./include/xen/interface/xen.h:30:0,
> >>>                       from ./include/xen/xen.h:29,
> >>>                       from sound/xen/xen_snd_front_shbuf.c:11:
> >>>     ./arch/x86/include/asm/xen/interface.h:92:21: error: unknown type name ‘uint64_t’
> >>>      DEFINE_GUEST_HANDLE(uint64_t);
> >>>                          ^
> >>> 			
> >>> Adding #include <linux/kernel.h> fixed the issue.
> >>>
> >>> Did you really test your patches with the latest Linus tree?
> >> My bad, it does build for ARM (which is my target), but also does
> >> need "#include <linux/kernel.h>" for x86 which I didn't build this time.
> >> Sorry about that.
> >>
> >> Do you want me to resend this single patch or you can make the change
> >> while applying?
> > Yes, it's fine.
> Thank you

FWIW, the patches are in topic/xen branch in sound.git tree, and I'll
keep boiling for a while to see if any issues are caught by 0day bot.


Takashi