The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: alsa-devel@alsa-project.org, Hui Wang <hui.wang@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559
Date: Tue, 30 Aug 2016 09:05:50 +0200	[thread overview]
Message-ID: <s5hoa4a3fe9.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAAd53p4stFs1GzGtbzRKVa6GVcotrFprsN_OO5ZA7jjQnf+3wg@mail.gmail.com>

On Tue, 30 Aug 2016 08:25:18 +0200,
Kai Heng Feng wrote:
> 
> On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Tue, 30 Aug 2016 07:27:41 +0200,
> > Kai-Heng Feng wrote:
> >>
> >> The subwoofer on Inspiron 7559 does not work originally.
> >> Applying a pin fixup can make it work.
> >>
> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >> ---
> >>  sound/pci/hda/patch_realtek.c | 11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >>
> >> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> >> index 7100f05..2a3dd18 100644
> >> --- a/sound/pci/hda/patch_realtek.c
> >> +++ b/sound/pci/hda/patch_realtek.c
> >> @@ -4855,6 +4855,7 @@ enum {
> >>       ALC221_FIXUP_HP_FRONT_MIC,
> >>       ALC292_FIXUP_TPT460,
> >>       ALC298_FIXUP_SPK_VOLUME,
> >> +     ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER,
> >>  };
> >>
> >>  static const struct hda_fixup alc269_fixups[] = {
> >> @@ -5516,6 +5517,15 @@ static const struct hda_fixup alc269_fixups[] = {
> >>               .chained = true,
> >>               .chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
> >>       },
> >> +     [ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
> >> +             .type = HDA_FIXUP_PINS,
> >> +             .v.pins = (const struct hda_pintbl[]) {
> >> +                     { 0x1b, 0x90170151 },
> >
> > What's the original value of this pin?
> >
> >
> > Takashi
> 
> The original value of 0x1b is 0x411111f0.

OK, so it was disabled.  Maybe better to mention it in the patch
description.


Takashi

  reply	other threads:[~2016-08-30  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30  5:27 [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559 Kai-Heng Feng
2016-08-30  5:33 ` Takashi Iwai
2016-08-30  6:25   ` Kai Heng Feng
2016-08-30  7:05     ` Takashi Iwai [this message]
2016-08-30  7:25       ` Kai Heng Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hoa4a3fe9.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hui.wang@canonical.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox