From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F020C47089 for ; Thu, 27 May 2021 06:14:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E570613D4 for ; Thu, 27 May 2021 06:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbhE0GPf (ORCPT ); Thu, 27 May 2021 02:15:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:46320 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbhE0GPe (ORCPT ); Thu, 27 May 2021 02:15:34 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622096040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0PohsSrFjqpl0gYvbtoAe9n4JF3cM3zBDn9ikvgJv98=; b=msbNX5EpKsQUDaxRwZMU+71+H9l8Yojm+vfRyvdkYJ6FGQDgrs1FmZlaZVq16zb4y2N5e3 +SMNKR8V0VDHr++yD4UwHr2Gonbb5G1uy1Xk2CkSO9wTpFDUI/xNk89WIY9zPJh2Eb4QGB 7K/6zfZhJhmgvvxAfbOVnHUx2JSxIHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622096040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0PohsSrFjqpl0gYvbtoAe9n4JF3cM3zBDn9ikvgJv98=; b=Vq3wzU658mu9+GB7ynLVH5yJY7itKb9t+HSkFn7VW6YoSu4M+kwL/XSPTGNFRhwF69MWYm OnQXYh5FdiGU89DQ== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AE3F3AC46; Thu, 27 May 2021 06:14:00 +0000 (UTC) Date: Thu, 27 May 2021 08:14:00 +0200 Message-ID: From: Takashi Iwai To: Jeremy Szu Cc: tiwai@suse.com, Jaroslav Kysela , Kailang Yang , Jian-Hong Pan , Hui Wang , Huacai Chen , PeiSen Hou , "moderated list:SOUND" , open list Subject: Re: [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 In-Reply-To: References: <20210519170357.58410-1-jeremy.szu@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 May 2021 04:00:34 +0200, Jeremy Szu wrote: > > Hi Takashi, > > Would you please help to review these quirks? Many thanks. Sorry, it was overlooked. Now applied all four patches. Thanks. Takashi > > > On Thu, May 20, 2021 at 1:04 AM Jeremy Szu wrote: > > > > The HP EliteBook 855 G8 Notebook PC is using ALC285 codec which needs > > ALC285_FIXUP_HP_MUTE_LED fixup to make it works. After applying the > > fixup, the mute/micmute LEDs work good. > > > > Signed-off-by: Jeremy Szu > > --- > > sound/pci/hda/patch_realtek.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index 552e2cb73291..9d68f591c6bf 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -8291,6 +8291,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > > + SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED), > > SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > > SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), > > SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), > > -- > > 2.31.1 > > > > > -- > Sincerely, > Jeremy Su >