public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/1] ALSA: hda/realtek: Sort alphanumerically the SND_PCI_QUIRK() entries.
Date: Thu, 11 Mar 2021 14:38:45 +0100	[thread overview]
Message-ID: <s5hpn05vmhm.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210311132741.80989-1-andriy.shevchenko@linux.intel.com>

On Thu, 11 Mar 2021 14:27:41 +0100,
Andy Shevchenko wrote:
> 
> Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance.
> No functional change implied.

I'd love to apply this kind of cleanups (and I do sometimes
partially), but practically seen, this may make the stable backporting
significantly harder because many quirk patches are backported to the
very old LTS kernels.  So, unless any specific reason (e.g. some
entries doubled or wrongly applied) is given, I'd avoid this full
plastic surgery.


thanks,

Takashi

  reply	other threads:[~2021-03-11 13:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 13:27 [PATCH v1 1/1] ALSA: hda/realtek: Sort alphanumerically the SND_PCI_QUIRK() entries Andy Shevchenko
2021-03-11 13:38 ` Takashi Iwai [this message]
2021-03-11 14:02   ` Andy Shevchenko
2021-03-11 14:06     ` Takashi Iwai
2021-03-11 14:22   ` Andy Shevchenko
2021-03-11 14:27     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpn05vmhm.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox