From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FB9C2D0A3 for ; Thu, 29 Oct 2020 07:49:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A41A214DB for ; Thu, 29 Oct 2020 07:49:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731977AbgJ2HtD (ORCPT ); Thu, 29 Oct 2020 03:49:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:60082 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731839AbgJ2Hs4 (ORCPT ); Thu, 29 Oct 2020 03:48:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9900FB02D; Thu, 29 Oct 2020 07:48:55 +0000 (UTC) Date: Thu, 29 Oct 2020 08:48:55 +0100 Message-ID: From: Takashi Iwai To: Coiby Xu Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH 01/25] ALSA: core: pcm: remove unnecessary CONFIG_PM_SLEEP In-Reply-To: <20201029074301.226644-1-coiby.xu@gmail.com> References: <20201029074301.226644-1-coiby.xu@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Oct 2020 08:42:37 +0100, Coiby Xu wrote: > > SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > Signed-off-by: Coiby Xu It caused compile warnings. Was it already addressed in general? Or we may use __maybe_unused attribute instead, but it's just a matter of taste. thanks, Takashi > --- > sound/core/pcm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/core/pcm.c b/sound/core/pcm.c > index be5714f1bb58..5a281ac92958 100644 > --- a/sound/core/pcm.c > +++ b/sound/core/pcm.c > @@ -599,7 +599,6 @@ static const struct attribute_group *pcm_dev_attr_groups[]; > * PM callbacks: we need to deal only with suspend here, as the resume is > * triggered either from user-space or the driver's resume callback > */ > -#ifdef CONFIG_PM_SLEEP > static int do_pcm_suspend(struct device *dev) > { > struct snd_pcm_str *pstr = container_of(dev, struct snd_pcm_str, dev); > @@ -608,7 +607,6 @@ static int do_pcm_suspend(struct device *dev) > snd_pcm_suspend_all(pstr->pcm); > return 0; > } > -#endif > > static const struct dev_pm_ops pcm_dev_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(do_pcm_suspend, NULL) > -- > 2.28.0 >