From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C1FCA9EA0 for ; Tue, 22 Oct 2019 16:08:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 797F120B7C for ; Tue, 22 Oct 2019 16:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732644AbfJVQIV (ORCPT ); Tue, 22 Oct 2019 12:08:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:57828 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731436AbfJVQIV (ORCPT ); Tue, 22 Oct 2019 12:08:21 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6F008B289; Tue, 22 Oct 2019 16:08:19 +0000 (UTC) Date: Tue, 22 Oct 2019 18:08:19 +0200 Message-ID: From: Takashi Iwai To: Aaron Ma Cc: , , , , Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623 In-Reply-To: <20191022153855.14368-1-aaron.ma@canonical.com> References: <20191022153855.14368-1-aaron.ma@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Oct 2019 17:38:55 +0200, Aaron Ma wrote: > > These 2 ThinkCentres installed a new realtek codec ID 0x623, > it has 2 front mics with the same location on pin 0x18 and 0x19. > > Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic > location to right, then pulseaudio can handle them. > One "Front Mic" and one "Mic" will be shown, and audio output works > fine. > > Signed-off-by: Aaron Ma I'd like to have Kailang's review about the new codec before applying. Kailang, could you take a look? thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index b000b36ac3c6..c34d8b435f58 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), > SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), > SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC), > + SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC), > + SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC), > SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI), > SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC), > SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI), > @@ -9187,6 +9189,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = { > HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269), > HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269), > HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269), > + HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269), > HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660", patch_alc861), > HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd), > HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861), > -- > 2.17.1 >