Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions

Takashi Iwai
2014-12-31T16:45:26Z

At Wed, 31 Dec 2014 17:41:33 +0100,
Rickard Strandqvist wrote:
>
> 2014-12-31 17:07 GMT+01:00 Takashi Iwai <tiwai@suse.de>:
>
> > At Wed, 31 Dec 2014 16:17:02 +0100,
> > Rickard Strandqvist wrote:
> > >
> > > Removes some functions that are not used anywhere:
> >
> > See Eliot's previous reply. There will be some code changes, so this
> > action is no-go as of now.
> >
> >
> > thanks,
> >
> > Takashi
> >
>
>
> Hi Takashi
>
> I have restored the function hpi_adapter_set_property() that Eliot wanted.
> And I also have diff the files against the linux-next, but that there are
> some notable differences.
>
> What is it you do not like about my current patch?

More code changes may land in near future, so removing functions isn't
good at all at this moment. We need to wait until the all things are
settled down. IOW, forget about this for a while :)

And please add Eliot to Cc at the next time.

thanks,

Takashi