From: Takashi Iwai <tiwai@suse.de>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
Alexander Stein <alexanders83@web.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] ALSA: atmel: fix building the ac97 driver for at91-multiplatform
Date: Thu, 25 Dec 2014 11:19:04 +0100 [thread overview]
Message-ID: <s5hppb8hw13.wl-tiwai@suse.de> (raw)
In-Reply-To: <1419160689-20447-1-git-send-email-alexandre.belloni@free-electrons.com>
At Sun, 21 Dec 2014 12:18:09 +0100,
Alexandre Belloni wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> at91 will no longer export the mach/cpu.h and mach/hardware.h header files
> in the future, which would break building the atmel ac97c driver.
>
> Since the cpu_is_* check is only used to find out whether we are running
> on avr32 or arm/at91, we can hardcode that check in the ARM case.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Link: http://www.spinics.net/lists/arm-kernel/msg382068.html
Is this targeted for 3.19 or 3.20?
thanks,
Takashi
> ---
> sound/atmel/ac97c.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index b59427d5a697..83975f8d5947 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -34,10 +34,10 @@
> #include <linux/platform_data/dma-dw.h>
> #include <linux/dma/dw.h>
>
> +#ifdef CONFIG_AVR32
> #include <mach/cpu.h>
> -
> -#ifdef CONFIG_ARCH_AT91
> -#include <mach/hardware.h>
> +#else
> +#define cpu_is_at32ap7000() 0
> #endif
>
> #include "ac97c.h"
> --
> 2.1.0
>
next prev parent reply other threads:[~2014-12-25 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 11:18 [PATCH v2] ALSA: atmel: fix building the ac97 driver for at91-multiplatform Alexandre Belloni
2014-12-25 10:19 ` Takashi Iwai [this message]
2014-12-25 10:48 ` Alexandre Belloni
2014-12-26 11:14 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hppb8hw13.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexanders83@web.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox