From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbaJJGWd (ORCPT ); Fri, 10 Oct 2014 02:22:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54255 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbaJJGWb (ORCPT ); Fri, 10 Oct 2014 02:22:31 -0400 From: Takashi Iwai Date: Fri, 10 Oct 2014 08:22:27 +0200 Message-ID: To: Sudip Mukherjee Cc: Joe Perches , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: au88x0: pr_* replaced with dev_* In-Reply-To: <20141010061702.GA4431@sudip-PC> References: <1412847397-4292-1-git-send-email-sudipm.mukherjee@gmail.com> <1412847397-4292-2-git-send-email-sudipm.mukherjee@gmail.com> <1412864283.3438.43.camel@joe-AO725> <20141010061702.GA4431@sudip-PC> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 10 Oct 2014 11:47:02 +0530, Sudip Mukherjee wrote: > > On Thu, Oct 09, 2014 at 07:18:03AM -0700, Joe Perches wrote: > > On Thu, 2014-10-09 at 15:38 +0200, Takashi Iwai wrote: > > > At Thu, 9 Oct 2014 15:06:37 +0530, > > > Sudip Mukherjee wrote: > > > > > diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c > > [] > > > > @@ -48,10 +48,10 @@ static void vortex_fix_latency(struct pci_dev *vortex) > > > > { > > > > int rc; > > > > if (!(rc = pci_write_config_byte(vortex, 0x40, 0xff))) { > > > > - pr_info( CARD_NAME > > > > + dev_info(&vortex->dev, CARD_NAME > > > > ": vortex latency is 0xff\n"); > > > > > > Omit the superfluous prefix when converting to dev_info() & co. > > > Other than that, looks good to me. > > > > Hi Sudip. > > > > Probably all the uses of CARD_NAME and "vortex" singly and > > in combination should be removed in all these conversions. > > > Hi Takashi and Joe, > I knew Takashi will ask to remove the CARD_NAME , so i have looked at the possibility while modifying the code. > CARD_NAME will be "Aureal Advantage" or "Aureal Vortex" or "Aureal Vortex 2" based on which chip is defined. > So I thought, if we remove the prefix then we will not get the exact card name. dev_* will print the device name as > CARD_NAME_SHORT which will be au8810 or au8820 or au8830. As the driver corresponds to each card as 1:1, it's fine to show only the driver name. Takashi