From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1759410AbYEMK7g@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759410AbYEMK7g (ORCPT <rfc822;w@1wt.eu>);
	Tue, 13 May 2008 06:59:36 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754148AbYEMK72
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 13 May 2008 06:59:28 -0400
Received: from mail.suse.de ([195.135.220.2]:43647 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754130AbYEMK72 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 13 May 2008 06:59:28 -0400
Date: Tue, 13 May 2008 12:59:26 +0200
Message-ID: <s5hprrqeagh.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Bryan Wu <cooloney@kernel.org>
Cc: liam.girdwood@wolfsonmicro.com, Cliff Cai <cliff.cai@analog.com>,
       Mark Brown <broonie@opensource.wolfsonmicro.com>,
       linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/1] [ASOC]: AD1980 audio codec ASOC driver
In-Reply-To: <1210589112-12208-1-git-send-email-cooloney@kernel.org>
References: <1210589112-12208-1-git-send-email-cooloney@kernel.org>
User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7
 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki)
 (+CVS-20070806) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 12 May 2008 18:45:12 +0800,
Bryan Wu wrote:
> diff --git a/sound/soc/codecs/ad1980.c b/sound/soc/codecs/ad1980.c
(snip)
> +static int ad1980_add_controls(struct snd_soc_codec *codec)
> +{
> +	int err, i;
> +
> +	for (i = 0; i < ARRAY_SIZE(ad1980_snd_ac97_controls); i++) {
> +		err = snd_ctl_add(codec->card, snd_soc_cnew( \

The backslash isn't needed.

> +static unsigned int ac97_read(struct snd_soc_codec *codec,
> +	unsigned int reg)
> +{
> +	u16 *cache = codec->reg_cache;
> +
> +	if (reg == AC97_RESET || reg == AC97_INT_PAGING || \
> +			reg == AC97_POWERDOWN || reg == AC97_EXTENDED_STATUS  \
> +			|| reg == AC97_VENDOR_ID1 || reg == AC97_VENDOR_ID2)

Ditto.  Maybe a switch is a better choice here.

> +		return soc_ac97_ops.read(codec->ac97, reg);
> +	else {
> +		reg = reg >> 1;
> +
> +		if (reg > (ARRAY_SIZE(ad1980_reg)))

Isn't it reg >= ARRAY_SIZE(ad1980_reg) ??

> +static int ac97_write(struct snd_soc_codec *codec, unsigned int reg,
> +	unsigned int val)
> +{
> +	u16 *cache = codec->reg_cache;
> +
> +	soc_ac97_ops.write(codec->ac97, reg, val);
> +	reg = reg >> 1;
> +	if (reg <= (ARRAY_SIZE(ad1980_reg)))

And reg < ARRAY_SIZE(ad1980_reg)


thanks,

Takashi