From: Takashi Iwai <tiwai@suse.de>
To: Keith Duthie <psycho@albatross.co.nz>
Cc: linux-kernel@vger.kernel.org, alsa-user@lists.sourceforge.net
Subject: Re: [PATCH] Fix apm suspend with cs4231 based sound cards
Date: Mon, 07 Jun 2004 19:01:27 +0200 [thread overview]
Message-ID: <s5hpt8b2tg8.wl@alsa2.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.53.0406080319560.27816@loki.albatross.co.nz>
At Tue, 8 Jun 2004 03:39:52 +1200 (NZST),
Keith Duthie wrote:
>
> The following patch (effectively a reversion of a change between alsa
> 0.9.4 and 0.9.5) fixes a problem whereby an APM suspend causes the
> program which is using the PCM device to enter the uninterruptible sleep
> state on resume and thus causes the sound device to be unusable.
>
> --- linux-2.6.5/sound/isa/cs423x/cs4231_lib.c~ Tue Jun 8 03:24:49 2004
> +++ linux-2.6.5/sound/isa/cs423x/cs4231_lib.c Tue Jun 8 03:24:52 2004
> @@ -1402,7 +1402,7 @@
> switch (rqst) {
> case PM_SUSPEND:
> if (chip->suspend) {
> - snd_pcm_suspend_all(chip->pcm);
> + // snd_pcm_suspend_all(chip->pcm);
> (*chip->suspend)(chip);
> }
> break;
Could you check whether the recent kernel works without this patch?
There was a mutex deadlock in the suspend code, and I guess it hit
you...
Takashi
next prev parent reply other threads:[~2004-06-07 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-07 15:39 [PATCH] Fix apm suspend with cs4231 based sound cards Keith Duthie
2004-06-07 17:01 ` Takashi Iwai [this message]
2004-06-08 2:51 ` Keith Duthie
2004-06-08 17:09 ` Keith Duthie
2004-06-13 8:37 ` Keith Duthie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpt8b2tg8.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=psycho@albatross.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox