From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264941AbUFGRBu (ORCPT ); Mon, 7 Jun 2004 13:01:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264943AbUFGRBt (ORCPT ); Mon, 7 Jun 2004 13:01:49 -0400 Received: from cantor.suse.de ([195.135.220.2]:65210 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S264941AbUFGRBr (ORCPT ); Mon, 7 Jun 2004 13:01:47 -0400 Date: Mon, 07 Jun 2004 19:01:27 +0200 Message-ID: From: Takashi Iwai To: Keith Duthie Cc: linux-kernel@vger.kernel.org, alsa-user@lists.sourceforge.net Subject: Re: [PATCH] Fix apm suspend with cs4231 based sound cards In-Reply-To: References: User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 13) (Rational FORTRAN) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 8 Jun 2004 03:39:52 +1200 (NZST), Keith Duthie wrote: > > The following patch (effectively a reversion of a change between alsa > 0.9.4 and 0.9.5) fixes a problem whereby an APM suspend causes the > program which is using the PCM device to enter the uninterruptible sleep > state on resume and thus causes the sound device to be unusable. > > --- linux-2.6.5/sound/isa/cs423x/cs4231_lib.c~ Tue Jun 8 03:24:49 2004 > +++ linux-2.6.5/sound/isa/cs423x/cs4231_lib.c Tue Jun 8 03:24:52 2004 > @@ -1402,7 +1402,7 @@ > switch (rqst) { > case PM_SUSPEND: > if (chip->suspend) { > - snd_pcm_suspend_all(chip->pcm); > + // snd_pcm_suspend_all(chip->pcm); > (*chip->suspend)(chip); > } > break; Could you check whether the recent kernel works without this patch? There was a mutex deadlock in the suspend code, and I guess it hit you... Takashi