From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDFEBC433E0 for ; Mon, 13 Jul 2020 06:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0B2120720 for ; Mon, 13 Jul 2020 06:44:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728785AbgGMGoS (ORCPT ); Mon, 13 Jul 2020 02:44:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:51428 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbgGMGoS (ORCPT ); Mon, 13 Jul 2020 02:44:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EAD8CAC82; Mon, 13 Jul 2020 06:44:18 +0000 (UTC) Date: Mon, 13 Jul 2020 08:44:16 +0200 Message-ID: From: Takashi Iwai To: Vasily Khoruzhick Cc: Jaroslav Kysela , Takashi Iwai , Pavel Machek , Kai-Heng Feng , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ALSA: line6: add hw monitor volume control for POD HD500 In-Reply-To: <20200713054635.58534-1-anarsoul@gmail.com> References: <20200713054635.58534-1-anarsoul@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jul 2020 07:46:35 +0200, Vasily Khoruzhick wrote: > > Add hw monitor volume control for POD HD500. The same change may > work for HD500X but I don't have it to test. > > Signed-off-by: Vasily Khoruzhick > --- > v3: - use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL > - use GFP_KERNEL instead of GFP_ATOMIC for allocating a message > - use lower case for float lookup table > v2: clamp volume value to [0, ARRAY_SIZE() -1] in > podhd_set_monitor_level() Almost good, but just a minor issue below: > +static void podhd_set_monitor_level(struct usb_line6_podhd *podhd, int value) > +{ (snip) > + buf = kmalloc(sizeof(msg), GFP_KERNEL); > + memcpy(buf, msg, sizeof(msg)); Missing NULL check of buf. Could you fix and resubmit? Thanks! Takashi