public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Benjamin Berg" <bberg@redhat.com>
Cc: <alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda/realtek: Limit mic boost on T480
Date: Wed, 14 Feb 2018 14:00:44 +0100	[thread overview]
Message-ID: <s5hr2pn6803.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180214122939.10069-1-bberg@redhat.com>

On Wed, 14 Feb 2018 13:29:39 +0100,
Benjamin Berg wrote:
> 
> The internal mic boost on the T480 is too high. Fix this by applying the
> ALC269_FIXUP_LIMIT_INT_MIC_BOOST fixup to the machine to limit the gain.
> 
> Signed-off-by: Benjamin Berg <bberg@redhat.com>
> Tested-by: Benjamin Berg <bberg@redhat.com>

Applying this quirk itself is OK, but just wonder whether this model
has a docking station port.  Recently we fixed the dock issue, and it
required to apply ALC298_FIXUP_TPT470_DOCK.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ce28f7ce64e6..8467ce3db767 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6510,6 +6510,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
>  	SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
>  	SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
> -- 
> 2.14.3
> 
> 

  reply	other threads:[~2018-02-14 13:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 12:29 [PATCH] ALSA: hda/realtek: Limit mic boost on T480 Benjamin Berg
2018-02-14 13:00 ` Takashi Iwai [this message]
2018-02-14 15:41   ` Benjamin Berg
2018-02-17 13:54     ` Peter FP1 Zhang
2018-02-20 15:48       ` Takashi Iwai
2018-02-20 16:07         ` Peter FP1 Zhang
2018-02-26  8:46         ` Peter FP1 Zhang
2018-03-06 10:04           ` Benjamin Berg
2018-03-06 10:55             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr2pn6803.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=bberg@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox