From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754729AbeBNNAr (ORCPT ); Wed, 14 Feb 2018 08:00:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:55735 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbeBNNAq (ORCPT ); Wed, 14 Feb 2018 08:00:46 -0500 Date: Wed, 14 Feb 2018 14:00:44 +0100 Message-ID: From: Takashi Iwai To: "Benjamin Berg" Cc: , "Jaroslav Kysela" , Subject: Re: [PATCH] ALSA: hda/realtek: Limit mic boost on T480 In-Reply-To: <20180214122939.10069-1-bberg@redhat.com> References: <20180214122939.10069-1-bberg@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Feb 2018 13:29:39 +0100, Benjamin Berg wrote: > > The internal mic boost on the T480 is too high. Fix this by applying the > ALC269_FIXUP_LIMIT_INT_MIC_BOOST fixup to the machine to limit the gain. > > Signed-off-by: Benjamin Berg > Tested-by: Benjamin Berg Applying this quirk itself is OK, but just wonder whether this model has a docking station port. Recently we fixed the dock issue, and it required to apply ALC298_FIXUP_TPT470_DOCK. thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index ce28f7ce64e6..8467ce3db767 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -6510,6 +6510,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > + SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), > SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), > SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), > -- > 2.14.3 > >