From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754662AbcCBPXp (ORCPT ); Wed, 2 Mar 2016 10:23:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:34424 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbcCBPXo (ORCPT ); Wed, 2 Mar 2016 10:23:44 -0500 Date: Wed, 02 Mar 2016 16:23:41 +0100 Message-ID: From: Takashi Iwai To: "Sudip Mukherjee" Cc: "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: portman2x4: fix NULL pointer dereference In-Reply-To: <1456918830-2675-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1456918830-2675-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Mar 2016 12:40:30 +0100, Sudip Mukherjee wrote: > > While registering pardev, the irq_func was also registered. As a result > when we tried to probe for the card, an interrupt was generated and in > the ISR we tried to dereference private_data. But private_data is still > NULL as we have not yet done portman_create(). Lets probe for the device > after card is created. > > Fixes: e6a1b7e88046 ("ALSA: portman2x4 - use new parport device model") > Signed-off-by: Sudip Mukherjee Applied, thanks. Takashi > --- > sound/drivers/portman2x4.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c > index 362533f..189e3e7 100644 > --- a/sound/drivers/portman2x4.c > +++ b/sound/drivers/portman2x4.c > @@ -762,11 +762,6 @@ static int snd_portman_probe(struct platform_device *pdev) > err = -EIO; > goto free_pardev; > } > - err = portman_probe(p); > - if (err) { > - err = -EIO; > - goto release_pardev; > - } > > if ((err = portman_create(card, pardev, &pm)) < 0) { > snd_printd("Cannot create main component\n"); > @@ -774,6 +769,12 @@ static int snd_portman_probe(struct platform_device *pdev) > } > card->private_data = pm; > card->private_free = snd_portman_card_private_free; > + > + err = portman_probe(p); > + if (err) { > + err = -EIO; > + goto __err; > + } > > if ((err = snd_portman_rawmidi_create(card)) < 0) { > snd_printd("Creating Rawmidi component failed\n"); > -- > 1.9.1 > >