From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932728AbaHZKda (ORCPT ); Tue, 26 Aug 2014 06:33:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40695 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757417AbaHZKd3 (ORCPT ); Tue, 26 Aug 2014 06:33:29 -0400 Date: Tue, 26 Aug 2014 12:33:28 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: pci: ctxfi: prink replacement In-Reply-To: <1409048004-19838-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 26 Aug 2014 15:43:24 +0530, Sudip Mukherjee wrote: > > printk replaced with corresponding pr_err and pr_alert > > Signed-off-by: Sudip Mukherjee > --- > > Initially started by copy-paste but as Takashi suggested it was done by a script. > bash script is as follows : > > OLD="printk(KERN_ERR \?" > OLD1="printk(KERN_ALERT \?" > NEW="pr_err(" > NEW1="pr_alert(" > TFILE="/tmp/out.tmp.$$" > for f in *.c > do > sed "s/$OLD/$NEW/g" "$f" > $TFILE && mv $TFILE "$f" > sed "s/$OLD1/$NEW1/g" "$f" > $TFILE && mv $TFILE "$f" > done All these can be a single call of sed :) > this patch will generate a warning from checkpatch for an unnecessary space before new line and has not been fixed as this patch is only for printk replacement. Better to put such information into the changelog. Do you have the patch reformatting the broken lines, too? If yes, I'll wait for it, as we should apply both such patches at once. Takashi