From: Takashi Iwai <tiwai@suse.de>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] wss_lib: fix suspend/resume
Date: Mon, 16 Jul 2012 11:24:25 +0200 [thread overview]
Message-ID: <s5hr4scgit2.wl%tiwai@suse.de> (raw)
In-Reply-To: <201207122330.34585.linux@rainbow-software.org>
At Thu, 12 Jul 2012 23:30:31 +0200,
Ondrej Zary wrote:
>
> By setting SNDRV_PCM_INFO_RESUME, wss_lib claims that it can restore the card
> state fully on resume. But in fact, it can't as DMA is not restored so any
> playback/capture running during suspend will fail to continue after resume.
>
> Remove SNDRV_PCM_INFO_RESUME flag from pcm info field to fix the problem.
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Applied now. Thanks.
Takashi
>
> --- a/sound/isa/wss/wss_lib.c
> +++ b/sound/isa/wss/wss_lib.c
> @@ -1456,7 +1456,6 @@ static struct snd_pcm_hardware snd_wss_playback =
> {
> .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
> SNDRV_PCM_INFO_MMAP_VALID |
> - SNDRV_PCM_INFO_RESUME |
> SNDRV_PCM_INFO_SYNC_START),
> .formats = (SNDRV_PCM_FMTBIT_MU_LAW | SNDRV_PCM_FMTBIT_A_LAW | SNDRV_PCM_FMTBIT_IMA_ADPCM |
> SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE),
>
> --
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
prev parent reply other threads:[~2012-07-16 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 21:30 [PATCH] wss_lib: fix suspend/resume Ondrej Zary
2012-07-16 9:24 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr4scgit2.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox