From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751721Ab2GPJY3 (ORCPT ); Mon, 16 Jul 2012 05:24:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44843 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754Ab2GPJY0 (ORCPT ); Mon, 16 Jul 2012 05:24:26 -0400 Date: Mon, 16 Jul 2012 11:24:25 +0200 Message-ID: From: Takashi Iwai To: Ondrej Zary Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, Kernel development list Subject: Re: [alsa-devel] [PATCH] wss_lib: fix suspend/resume In-Reply-To: <201207122330.34585.linux@rainbow-software.org> References: <201207122330.34585.linux@rainbow-software.org> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 12 Jul 2012 23:30:31 +0200, Ondrej Zary wrote: > > By setting SNDRV_PCM_INFO_RESUME, wss_lib claims that it can restore the card > state fully on resume. But in fact, it can't as DMA is not restored so any > playback/capture running during suspend will fail to continue after resume. > > Remove SNDRV_PCM_INFO_RESUME flag from pcm info field to fix the problem. > > Signed-off-by: Ondrej Zary Applied now. Thanks. Takashi > > --- a/sound/isa/wss/wss_lib.c > +++ b/sound/isa/wss/wss_lib.c > @@ -1456,7 +1456,6 @@ static struct snd_pcm_hardware snd_wss_playback = > { > .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED | > SNDRV_PCM_INFO_MMAP_VALID | > - SNDRV_PCM_INFO_RESUME | > SNDRV_PCM_INFO_SYNC_START), > .formats = (SNDRV_PCM_FMTBIT_MU_LAW | SNDRV_PCM_FMTBIT_A_LAW | SNDRV_PCM_FMTBIT_IMA_ADPCM | > SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE), > > -- > Ondrej Zary > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >