From: Takashi Iwai <tiwai@suse.de>
To: Pavel Machek <pavel@suse.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
LKML <linux-kernel@vger.kernel.org>,
ACPI mailing list <acpi-devel@lists.sourceforge.net>,
Andrew Morton <akpm@osdl.org>,
alsa-devel@alsa-project.org
Subject: Re: [ACPI] Re: [Alsa-devel] [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (1/2)
Date: Thu, 28 Jul 2005 10:06:35 +0200 [thread overview]
Message-ID: <s5hr7djtkvo.wl%tiwai@suse.de> (raw)
In-Reply-To: <20050727205249.GA708@openzaurus.ucw.cz>
At Wed, 27 Jul 2005 22:52:49 +0200,
Pavel Machek wrote:
>
> Hi!
>
> > > The following patch adds free_irq() and request_irq() to the suspend and
> > > resume, respectively, routines in the snd_intel8x0 driver.
> >
> > The patch looks OK to me although I have some concerns.
> >
> > - The error in resume can't be handled properly.
> >
> > What should we do for the error of request_irq()?
> >
> > - Adding this to all drivers seem too much.
>
> There's probably no other way. Talk to Len Brown.
>
> > We just need to stop the irq processing until resume, so something
> > like suspend_irq(irq, dev_id) and resume_irq(irq, dev_id) would be
> > more uesful?
>
> Its more complex than that. Irq numbers may change during resume.
Hmm, then the patch looks wrong. It assumes that the irq number is
as same as before suspend.
Sorry for ignorance, but, is only irq affected? Are the other
resources like ioport consistent after resume?
Takashi
next prev parent reply other threads:[~2005-07-28 8:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-26 10:47 [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (0/2) Rafael J. Wysocki
2005-07-26 10:51 ` [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (1/2) Rafael J. Wysocki
2005-07-27 8:53 ` [Alsa-devel] " Takashi Iwai
2005-07-27 20:52 ` [ACPI] " Pavel Machek
2005-07-28 8:06 ` Takashi Iwai [this message]
2005-07-28 8:31 ` Pavel Machek
2005-07-28 8:37 ` Shaohua Li
2005-07-28 8:43 ` Rafael J. Wysocki
2005-07-28 8:48 ` Shaohua Li
2005-07-28 11:18 ` Rafael J. Wysocki
2005-07-26 10:54 ` [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (2/2) Rafael J. Wysocki
2005-07-26 12:25 ` [ACPI] " Carl-Daniel Hailfinger
2005-07-26 21:02 ` Rafael J. Wysocki
2005-07-26 21:11 ` Peter Buckingham
2005-07-26 21:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr7djtkvo.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=acpi-devel@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox