From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262260AbUKVRf3 (ORCPT ); Mon, 22 Nov 2004 12:35:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262256AbUKVRfX (ORCPT ); Mon, 22 Nov 2004 12:35:23 -0500 Received: from news.suse.de ([195.135.220.2]:17086 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S262260AbUKVR2e (ORCPT ); Mon, 22 Nov 2004 12:28:34 -0500 Date: Mon, 22 Nov 2004 18:28:34 +0100 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] [2.6 patch] ALSA PCI drivers: misc cleanups In-Reply-To: <20041121235855.GI13254@stusta.de> References: <20041121235855.GI13254@stusta.de> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 22 Nov 2004 00:58:55 +0100, Adrian Bunk wrote: > > The patch below does the following cleanups under sound/pci/ : > - cs46xx/dsp_spos_scb_lib.c: cs46xx_dsp_create_filter_scb > - cs46xx/dsp_spos_scb_lib.c: cs46xx_dsp_create_output_snoop_scb I'd rather like to keep them with #if 0. These functions will be needed when someone extends the DSP code. > --- linux-2.6.10-rc2-mm2-full/sound/pci/ac97/ac97_local.h.old 2004-11-22 00:00:07.000000000 +0100 > +++ linux-2.6.10-rc2-mm2-full/sound/pci/ac97/ac97_local.h 2004-11-22 00:00:27.000000000 +0100 > @@ -45,9 +45,6 @@ > int snd_ac97_page_get_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol); > int snd_ac97_page_put_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol); > int snd_ac97_try_bit(ac97_t * ac97, int reg, int bit); > -int snd_ac97_remove_ctl(ac97_t *ac97, const char *name, const char *suffix); > -int snd_ac97_rename_ctl(ac97_t *ac97, const char *src, const char *dst, const char *suffix); > -int snd_ac97_swap_ctl(ac97_t *ac97, const char *s1, const char *s2, const char *suffix); They are intentionally non-static to allow ac97_patch.c functions to access them (in future). Please keep them so. Otherwise the patch looks fine. Thanks! Takashi