Re: [PATCH 2.6.8-rc2] intel8x0.c to include CK804 audio support

Andrew Morton
2004-07-27T01:10:21Z

"Andrew Chew" <achew@nvidia.com> wrote:
>
> I sincerely apologize about the mangled patch. I'll be more careful
> next time (and check my mailer settings).

Is OK - you're in good company ;)

> The #ifdef was for consistency (I noticed that there were other IDs
> similarly defined in intel8x0.c). I don't see why we'd need it, either.
> We should probably remove PCI_DEVICE_ID_NVIDIA_MCP2_AUDIO and
> PCI_DEVICE_ID_NVIDIA_MCP3_AUDIO #defines from intel8x0.c as well, as
> they're similarly redundant. For that matter, why not remove all of the
> PCI_DEVICE_ID_* #defines from the intel8x0.c driver, and make sure the
> device IDs are defined in pci_ids.h.
>
> Want me to submit a patch for that?

Let's leave that up to Jeff.