From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S265719AbUFIJKN@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S265719AbUFIJKN (ORCPT <rfc822;willy@w.ods.org>);
	Wed, 9 Jun 2004 05:10:13 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265761AbUFIJKN
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 9 Jun 2004 05:10:13 -0400
Received: from cantor.suse.de ([195.135.220.2]:40918 "EHLO Cantor.suse.de")
	by vger.kernel.org with ESMTP id S265719AbUFIJKJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Jun 2004 05:10:09 -0400
Date: Wed, 09 Jun 2004 11:10:08 +0200
Message-ID: <s5hr7sp14i7.wl@alsa2.suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: Remove subsystem-specific malloc (7/8)
In-Reply-To: <200406082125.i58LP8rC016229@melkki.cs.helsinki.fi>
References: <200406082125.i58LP8rC016229@melkki.cs.helsinki.fi>
User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 13) (Rational FORTRAN) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 9 Jun 2004 00:25:08 +0300,
Pekka J Enberg wrote:
> 
> --- linux-2.6.6/sound/arm/sa11xx-uda1341.c	2004-06-08 23:57:25.623550760 +0300
> +++ alsa-2.6.6/sound/arm/sa11xx-uda1341.c	2004-06-05 20:30:06.000000000 +0300
(snip)
> @@ -1010,6 +1010,7 @@ static int __init sa11xx_uda1341_init(vo
>  static void __exit sa11xx_uda1341_exit(void)
>  {
>  	snd_card_free(sa11xx_uda1341->card);
> +	kfree(sa11xx_uda1341);
>  }

this causes double-free.
sa11xx_uda1341 is already released in snd_sa11xx_uda1341_free(),
invoked from snd_card_free().


Takashi