From: Takashi Iwai <tiwai@suse.de>
To: arjanv@redhat.com
Cc: Johannes Stezenbach <js@convergence.de>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.1-mm4: ALSA es1968 DMA alloc problem
Date: Mon, 19 Jan 2004 17:56:21 +0100 [thread overview]
Message-ID: <s5hr7xv6fnu.wl@alsa2.suse.de> (raw)
In-Reply-To: <1074530601.4443.3.camel@laptop.fenrus.com>
Hi,
At Mon, 19 Jan 2004 17:43:22 +0100,
Arjan van de Ven wrote:
>
> [1 <text/plain (quoted-printable)>]
> On Mon, 2004-01-19 at 17:29, Takashi Iwai wrote:
> > At Sat, 17 Jan 2004 17:10:13 +0100,
>
>
> all throughout the patch:
> pci_set_dma_mask() and friends need their return value checked!
it does check. the patch replaces the code like
if (! pci_dma_support(pci, XXXX))
error;
pci_set_dma_mask(pci, XXXX);
with
if (pci_dma_set_mask(pci, XXXX))
error;
(there is one place which doesn't check, but it's in the resume
callback.)
the problem is that in the former version only
pci_set_consistent_dma_mask() was called without pci_dma_set_mask().
apparently, this doesn't work properly.
ciao,
Takashi
next prev parent reply other threads:[~2004-01-19 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-17 16:10 2.6.1-mm4: ALSA es1968 DMA alloc problem Johannes Stezenbach
2004-01-19 16:29 ` Takashi Iwai
2004-01-19 16:43 ` Arjan van de Ven
2004-01-19 16:56 ` Takashi Iwai [this message]
2004-01-19 17:05 ` Arjan van de Ven
2004-01-19 17:14 ` Takashi Iwai
2004-01-19 18:05 ` Takashi Iwai
2004-01-20 1:17 ` Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr7xv6fnu.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=arjanv@redhat.com \
--cc=js@convergence.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox