From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E85E9C433EF for ; Fri, 4 Mar 2022 08:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235007AbiCDIwS (ORCPT ); Fri, 4 Mar 2022 03:52:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232134AbiCDIwO (ORCPT ); Fri, 4 Mar 2022 03:52:14 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F318519DEA7; Fri, 4 Mar 2022 00:51:26 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A4C8E21136; Fri, 4 Mar 2022 08:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646383885; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slqWuDwOoH/Q5XlOhkioyiGZ0ilW0OBu5hUs4LHxwxA=; b=CJjoqG1Kh563odELWTDZkXLiqEDm+WjyISHd5xwzsNAhGqqw/VajH3xLlE9tlJxkcLbASy ReDQ5Jayk8E+eQfPurL4RYjuWWXJm+lEhQPdHFVW96qv4olsmKsHXsbbP38hziUezy3BCc HiCbWHBhoIqdWwJ5myzr10lydClipoY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646383885; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slqWuDwOoH/Q5XlOhkioyiGZ0ilW0OBu5hUs4LHxwxA=; b=nGdOjxJiB8ElSvqgH5B1ZDOIKsxBc3K6YbRTDuh+qkY2fD/s98hl908MXPlc1WKYs2oj1s X7HLpiTPpHQZntCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 877EAA3B83; Fri, 4 Mar 2022 08:51:25 +0000 (UTC) Date: Fri, 04 Mar 2022 09:51:25 +0100 Message-ID: From: Takashi Iwai To: Colin Ian King Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] ALSA: echoaudio: remove redundant assignment to variable bytes In-Reply-To: <20220302170728.1094633-1-colin.i.king@gmail.com> References: <20220302170728.1094633-1-colin.i.king@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Mar 2022 18:07:28 +0100, Colin Ian King wrote: > > The variable bytes is being assigned a value that is never read, it > is being re-assigned inside a following if block. The assignment is > redundant and can be removed. > > Cleans up clang scan build warning: > sound/pci/echoaudio/midi.c:211:9: warning: Although the value stored > to 'bytes' is used in the enclosing expression, the value is never > actually read from 'bytes' [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Thanks, applied. Takashi