From: Takashi Iwai <tiwai@suse.de>
To: Zhen Ni <nizhen@uniontech.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: intel_hdmi: Fix reference to PCM buffer address
Date: Wed, 02 Mar 2022 09:27:45 +0100 [thread overview]
Message-ID: <s5hsfs0oj26.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220302074241.30469-1-nizhen@uniontech.com>
On Wed, 02 Mar 2022 08:42:41 +0100,
Zhen Ni wrote:
>
> PCM buffers might be allocated dynamically when the buffer
> preallocation failed or a larger buffer is requested, and it's not
> guaranteed that substream->dma_buffer points to the actually used
> buffer. The driver needs to refer to substream->runtime->dma_addr
> instead for the buffer address.
>
> Signed-off-by: Zhen Ni <nizhen@uniontech.com>
Thanks, applied now with Cc-to-stable.
I guess the had_pcm_mmap() can be dropped completely and replaced with
the standard mmap helper, as what we really want is rather wc.
But it can be done for 5.18.
Takashi
prev parent reply other threads:[~2022-03-02 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 7:42 [PATCH] ALSA: intel_hdmi: Fix reference to PCM buffer address Zhen Ni
2022-03-02 8:27 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsfs0oj26.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nizhen@uniontech.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox