From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1D17AC433EF
	for <linux-kernel@archiver.kernel.org>; Wed,  2 Mar 2022 08:27:53 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S240109AbiCBI2d (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 2 Mar 2022 03:28:33 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38658 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S235447AbiCBI2b (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 2 Mar 2022 03:28:31 -0500
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08693387B7
        for <linux-kernel@vger.kernel.org>; Wed,  2 Mar 2022 00:27:47 -0800 (PST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out1.suse.de (Postfix) with ESMTP id 3D77A218EE;
        Wed,  2 Mar 2022 08:27:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1646209666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=9TSNZrBpMR+dD20Bm8WKUFJxKv90bww4RaWEH7qCn6E=;
        b=vDMBA6VN228hGxDmm4+6hI/zXP5PucvtznNszbtFx+r1zlfTWAjzsBSAEkQQKSjaRTgrN9
        2yI1ubP9jcE0vQwN0nQjXKP720KLsPoOiUkmUlnfShp0LUsNe9DS0cHstw8yLJBoQMiqne
        ehKo0tf1a+Sqd9NQA8vm2ymLCMDObfc=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1646209666;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=9TSNZrBpMR+dD20Bm8WKUFJxKv90bww4RaWEH7qCn6E=;
        b=2eissv3EzPZGWaDipG/hR9vy55/Tv2Dhw65glMJwAGemow5y6iG+53f2gHk54jMzG6rmbh
        VunqKtNcIDmHnNBw==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 23217A3B84;
        Wed,  2 Mar 2022 08:27:45 +0000 (UTC)
Date:   Wed, 02 Mar 2022 09:27:45 +0100
Message-ID: <s5hsfs0oj26.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Zhen Ni <nizhen@uniontech.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: intel_hdmi: Fix reference to PCM buffer address
In-Reply-To: <20220302074241.30469-1-nizhen@uniontech.com>
References: <20220302074241.30469-1-nizhen@uniontech.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 02 Mar 2022 08:42:41 +0100,
Zhen Ni wrote:
> 
> PCM buffers might be allocated dynamically when the buffer
> preallocation failed or a larger buffer is requested, and it's not
> guaranteed that substream->dma_buffer points to the actually used
> buffer.  The driver needs to refer to substream->runtime->dma_addr
> instead for the buffer address.
> 
> Signed-off-by: Zhen Ni <nizhen@uniontech.com>

Thanks, applied now with Cc-to-stable.

I guess the had_pcm_mmap() can be dropped completely and replaced with
the standard mmap helper, as what we really want is rather wc.
But it can be done for 5.18.


Takashi