From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id EFA20C4167B
	for <linux-kernel@archiver.kernel.org>; Mon,  7 Feb 2022 16:15:19 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1380408AbiBGQOs (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 7 Feb 2022 11:14:48 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50334 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S237064AbiBGQKY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 7 Feb 2022 11:10:24 -0500
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5847C0401D8;
        Mon,  7 Feb 2022 08:10:20 -0800 (PST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out2.suse.de (Postfix) with ESMTP id 92DA91F37E;
        Mon,  7 Feb 2022 16:10:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1644250219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=dVOa8XGIp5DLIL4tTlJLbaMRsQatnR/OajkKQCMIv8U=;
        b=i8IRCgVhiupXohd6nYjhcDJUvvrcp2XSHParhS+S7TfdC3jpgm/y+24HuywhNi1AmEzKZt
        Z0iVoFCBfo9QqquI90ElG+zB6aLQnxBRIHzxOfnetNHiIB+7gKODbTWG6zlDANP87yVxJr
        qb+v8QItTT0Kotabn2cI8lRrlFK5Hf8=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1644250219;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=dVOa8XGIp5DLIL4tTlJLbaMRsQatnR/OajkKQCMIv8U=;
        b=jlYuTVoyoBavi0rBZBvHmXcBmnGSrWbV04t0gJrGclpL8WyBzV9nqLEczhKrIRYzJVyBnA
        Dhj5Estxdal8w3Ag==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 76A16A3B83;
        Mon,  7 Feb 2022 16:10:19 +0000 (UTC)
Date:   Mon, 07 Feb 2022 17:10:19 +0100
Message-ID: <s5hsfsuu07o.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: remove redundant assignment to variable c
In-Reply-To: <20220207140617.341172-1-colin.i.king@gmail.com>
References: <20220207140617.341172-1-colin.i.king@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 07 Feb 2022 15:06:17 +0100,
Colin Ian King wrote:
> 
> The variable c is being initialized in an outer for-loop and also
> re-initialized inside an inner for-loop. The first initialization
> is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

The code change looks OK, but when I apply your patch now, git-am
converts the Author address to your new @intel.com, and this
mismatches with the address in Signed-off-by.  Should I keep the
original gmail address, or would you fix up your Signed-off-by (and
From) for avoiding those inconsistency?


thanks,

Takashi