From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B49C43381 for ; Mon, 15 Mar 2021 07:50:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1996064E67 for ; Mon, 15 Mar 2021 07:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbhCOHuG (ORCPT ); Mon, 15 Mar 2021 03:50:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:44310 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbhCOHt5 (ORCPT ); Mon, 15 Mar 2021 03:49:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5CB30ABD7; Mon, 15 Mar 2021 07:49:56 +0000 (UTC) Date: Mon, 15 Mar 2021 08:49:56 +0100 Message-ID: From: Takashi Iwai To: Vitaly Rodionov Cc: Jaroslav Kysela , Takashi Iwai , , , , Stefan Binding Subject: Re: [PATCH v1 4/4] ALSA: hda/cirrus: Make CS8409 driver more generic by using fixups. In-Reply-To: <20210313113410.90088-5-vitalyr@opensource.cirrus.com> References: <20210313113410.90088-1-vitalyr@opensource.cirrus.com> <20210313113410.90088-5-vitalyr@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Mar 2021 12:34:10 +0100, Vitaly Rodionov wrote: > @@ -1357,6 +1362,22 @@ static const struct hda_verb cs8409_cs42l42_init_verbs[] = { > { 0x47, AC_VERB_SET_PROC_COEF, 0x0080 }, /* I2C mode */ > { 0x47, AC_VERB_SET_COEF_INDEX, 0x005b }, /* Set I2C bus speed */ > { 0x47, AC_VERB_SET_PROC_COEF, 0x0200 }, /* 100kHz I2C_STO = 2 */ > + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0xF0 }, /* Widget node ASP-1-TX */ > + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x20 }, > + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0x21 }, > + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x04 }, > + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0x50 }, /* Widget node ASP-1-RX0 */ > + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x20 }, > + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0xa1 }, > + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x04 }, > + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0xF0 }, /* Widget node ASP-2-TX */ > + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x00 }, > + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0x10 }, > + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x90 }, > + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0x90 }, /* Widget node DMIC-1 */ > + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x00 }, > + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0xA0 }, > + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x90 }, Those widgets are all pin widgets, right? If so, setting via the pincfg table would be more suitable, as it's cached and exposed via sysfs for debugging. thanks, Takashi