From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB8B9C433E0 for ; Fri, 15 Jan 2021 15:53:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79D9F238D7 for ; Fri, 15 Jan 2021 15:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732114AbhAOPw5 (ORCPT ); Fri, 15 Jan 2021 10:52:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:46310 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbhAOPw5 (ORCPT ); Fri, 15 Jan 2021 10:52:57 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 76BEFAB7F; Fri, 15 Jan 2021 15:52:15 +0000 (UTC) Date: Fri, 15 Jan 2021 16:52:15 +0100 Message-ID: From: Takashi Iwai To: Colin King Cc: Jaroslav Kysela , Takashi Iwai , Alexander Tsoy , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed In-Reply-To: <20210115154151.75022-1-colin.king@canonical.com> References: <20210115154151.75022-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Jan 2021 16:41:51 +0100, Colin King wrote: > > From: Colin Ian King > > Variable param_period_time_if_needed is being initialized with a value > that is never read, the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King This doesn't look applicable to the latest tree. Could you check again? thanks, Takashi > --- > sound/usb/pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > index f71965bf815f..ed654338f6b7 100644 > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c > @@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre > { > const struct audioformat *fp; > unsigned int pt, ptmin; > - int param_period_time_if_needed = -1; > + int param_period_time_if_needed; > int err; > > runtime->hw.formats = subs->formats; > -- > 2.29.2 >