From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=k3Bv=C6=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6F65DC43463
	for <linux-kernel@archiver.kernel.org>; Mon, 21 Sep 2020 08:40:30 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 2967420773
	for <linux-kernel@archiver.kernel.org>; Mon, 21 Sep 2020 08:40:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726589AbgIUIk3 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 21 Sep 2020 04:40:29 -0400
Received: from mx2.suse.de ([195.135.220.15]:48666 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726236AbgIUIk2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Sep 2020 04:40:28 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id 85BB8B4FC;
        Mon, 21 Sep 2020 08:41:03 +0000 (UTC)
Date:   Mon, 21 Sep 2020 10:40:27 +0200
Message-ID: <s5hsgbbplok.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     tiwai@suse.com, Jaroslav Kysela <perex@perex.cz>,
        "Alexander A. Klimov" <grandmaster@al2klimov.de>,
        Andrew Oakley <andrew@adoakley.name>,
        Chris Boyle <chris@boyle.name>,
        alsa-devel@alsa-project.org (moderated list:SOUND),
        linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control"
In-Reply-To: <20200915103925.12777-1-kai.heng.feng@canonical.com>
References: <20200915103925.12777-1-kai.heng.feng@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 15 Sep 2020 12:39:23 +0200,
Kai-Heng Feng wrote:
> 
> This reverts commit 34dedd2a83b241ba6aeb290260313c65dc58660e.
> 
> According to Realtek, volume FU works for line-in.
> 
> I can confirm volume control works after device firmware is updated.

A slight concern is what happens if you apply this change to the
device before the firmware update.

Also, after this revert, does the mixer control appear properly?


thanks,

Takashi

> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  sound/usb/mixer_maps.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
> index 5b43e9e40e49..c369c81e74c4 100644
> --- a/sound/usb/mixer_maps.c
> +++ b/sound/usb/mixer_maps.c
> @@ -371,7 +371,6 @@ static const struct usbmix_name_map asus_rog_map[] = {
>  };
>  
>  static const struct usbmix_name_map lenovo_p620_rear_map[] = {
> -	{ 19, NULL, 2 }, /* FU, Volume */
>  	{ 19, NULL, 12 }, /* FU, Input Gain Pad */
>  	{}
>  };
> -- 
> 2.17.1
>