public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Ayman Bagabas" <ayman.bagabas@gmail.com>
Cc: <alsa-devel@alsa-project.org>,
	"Hui Wang" <hui.wang@canonical.com>,
	"Andy Shevchenko" <andy@infradead.org>,
	"Darren Hart" <dvhart@infradead.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Kailang Yang" <kailang@realtek.com>,
	<linux-kernel@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED
Date: Tue, 13 Nov 2018 18:32:30 +0100	[thread overview]
Message-ID: <s5hsh04c28h.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181111190250.6055-4-ayman.bagabas@gmail.com>

On Sun, 11 Nov 2018 20:02:45 +0100,
Ayman Bagabas wrote:
> 
> Some of Huawei laptops come with a LED in the micmute key. This patch
> enables and disable this LED accordingly.

disable what?

> This enables micmute LED for:
> 1. Matebook X (19e5:3200), (19e5:3201)
> 2. Matebook X Pro (19e5:3204)
> 
> Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>

The code changes are mostly OK.  Just a minor nitpicking:

> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5374,6 +5374,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec,
>  /* for alc295_fixup_hp_top_speakers */
>  #include "hp_x360_helper.c"
>  
> +/* for alc_fixup_huawei_micmute_led */

This should be alc_fixup_huawei_wmi */

With that fix,
  Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

  reply	other threads:[~2018-11-13 17:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 19:02 [PATCH v5 0/3] Huawei laptops Ayman Bagabas
2018-11-11 19:02 ` [PATCH v5 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
2018-11-11 19:02 ` [PATCH v5 2/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas
2018-11-13 17:30   ` Takashi Iwai
2018-11-11 19:02 ` [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED Ayman Bagabas
2018-11-13 17:32   ` Takashi Iwai [this message]
2018-11-13 18:51     ` Andy Shevchenko
     [not found]       ` <CAB3uXr5NrrQ4zLvpXM51EJtjJAAScDw_daj5bY40xtsUnj=RGg@mail.gmail.com>
2018-11-14 10:47         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsh04c28h.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy@infradead.org \
    --cc=ayman.bagabas@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=hui.wang@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox