From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751541AbdFGVkX (ORCPT ); Wed, 7 Jun 2017 17:40:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:38978 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751072AbdFGVkV (ORCPT ); Wed, 7 Jun 2017 17:40:21 -0400 Date: Wed, 07 Jun 2017 23:40:19 +0200 Message-ID: From: Takashi Iwai To: "Matthias Kaehlcke" Cc: "Liam Girdwood" , "Vinod Koul" , "Mark Brown" , "Jaroslav Kysela" , , "Douglas Anderson" , Subject: Re: [PATCH] ASoC: Intel: sst: Remove unused function sst_restore_shim64() In-Reply-To: <20170523001258.81618-1-mka@chromium.org> References: <20170523001258.81618-1-mka@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2017 02:12:58 +0200, Matthias Kaehlcke wrote: > > Looks like the function has never been used since it was added by commit > b0d94acd634a ("ASoC: Intel: mrfld - add shim save restore"). Removing it > fixes the following warning when building with clang: > > sound/soc/intel/atom/sst/sst.c:360:20: error: unused function > 'sst_restore_shim64' [-Werror,-Wunused-function] > > Signed-off-by: Matthias Kaehlcke Hmm, although this patch was already merged, I now think this is rather a bug. If the restore is never executed, why the counterpart, sst_save_shim64() is required at all at runtime suspend? Vinod? thanks, Takashi > --- > sound/soc/intel/atom/sst/sst.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c > index f9ba71315e33..fb608d3a90c8 100644 > --- a/sound/soc/intel/atom/sst/sst.c > +++ b/sound/soc/intel/atom/sst/sst.c > @@ -397,22 +397,6 @@ static inline void sst_save_shim64(struct intel_sst_drv *ctx, > spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); > } > > -static inline void sst_restore_shim64(struct intel_sst_drv *ctx, > - void __iomem *shim, > - struct sst_shim_regs64 *shim_regs) > -{ > - unsigned long irq_flags; > - > - /* > - * we only need to restore IMRX for this case, rest will be > - * initialize by FW or driver when firmware is loaded > - */ > - spin_lock_irqsave(&ctx->ipc_spin_lock, irq_flags); > - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx); > - sst_shim_write64(shim, SST_CSR, shim_regs->csr); > - spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); > -} > - > void sst_configure_runtime_pm(struct intel_sst_drv *ctx) > { > pm_runtime_set_autosuspend_delay(ctx->dev, SST_SUSPEND_DELAY); > -- > 2.13.0.303.g4ebf302169-goog > >