From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751528AbaLaRr0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 31 Dec 2014 12:47:26 -0500
Received: from cantor2.suse.de ([195.135.220.15]:33322 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750956AbaLaRrZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 31 Dec 2014 12:47:25 -0500
Date: Wed, 31 Dec 2014 18:47:21 +0100
Message-ID: <s5hsifvg192.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: eliot@blennerhassett.gen.nz, Jaroslav Kysela <perex@perex.cz>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions
In-Reply-To: <CAKXHbyPEr+HOAXB8ibtpYidh_GVD0qAgcQK3A4kXpgVWgLbtQA@mail.gmail.com>
References: <1420039022-10018-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
	<s5h7fx7hkga.wl-tiwai@suse.de>
	<CAKXHbyOEp=juzjaqsNt9RXn02VYDJXvESK4o_vAhMtFGmK=dHA@mail.gmail.com>
	<s5hvbkrg44c.wl-tiwai@suse.de>
	<CAKXHbyPEr+HOAXB8ibtpYidh_GVD0qAgcQK3A4kXpgVWgLbtQA@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 31 Dec 2014 18:07:36 +0100,
Rickard Strandqvist wrote:
> 
> 2014-12-31 17:45 GMT+01:00 Takashi Iwai <tiwai@suse.de>:
> 
> > At Wed, 31 Dec 2014 17:41:33 +0100,
> > Rickard Strandqvist wrote:
> > >
> > > 2014-12-31 17:07 GMT+01:00 Takashi Iwai <tiwai@suse.de>:
> > >
> > > > At Wed, 31 Dec 2014 16:17:02 +0100,
> > > > Rickard Strandqvist wrote:
> > > > >
> > > > > Removes some functions that are not used anywhere:
> > > >
> > > > See Eliot's previous reply.  There will be some code changes, so this
> > > > action is no-go as of now.
> > > >
> > > >
> > > > thanks,
> > > >
> > > > Takashi
> > > >
> > >
> > >
> > > Hi Takashi
> > >
> > > I have restored the function hpi_adapter_set_property() that Eliot
> > wanted.
> > > And I also have diff the files against the linux-next, but that there are
> > > some notable differences.
> > >
> > > What is it you do not like about my current patch?
> >
> > More code changes may land in near future, so removing functions isn't
> > good at all at this moment.  We need to wait until the all things are
> > settled down.  IOW, forget about this for a while :)
> >
> > And please add Eliot to Cc at the next time.
> >
> >
> > thanks,
> >
> > Takashi
> >
> 
> 
> + Eliot
> 
> Hi
> 
> Strange, because I ask specifically if it was just one function Eliot objected
> to, and I therefore could resend the patch.

In general, it's bad to do a task like this kind of cleanups during
the code change is planned in future.  There is more risk than gain in
such a case.

You can do it for the really stalling development codes, of course.


Takashi