From: Takashi Iwai <tiwai@suse.de>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: perex@perex.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound/core.h: include sound/driver.h
Date: Mon, 17 Dec 2007 10:30:01 +0100 [thread overview]
Message-ID: <s5hsl211xeu.wl%tiwai@suse.de> (raw)
In-Reply-To: <20071216015825.GA26986@joi>
At Sun, 16 Dec 2007 02:58:31 +0100,
Marcin Slusarz wrote:
>
> On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote:
> > At Sat, 8 Dec 2007 21:50:45 +0100,
> > Marcin Ślusarz wrote:
> > >
> > > sound/core.h: include sound/driver.h
> > >
> > > include sound/driver.h in sound/core.h because core.h
> > > uses SNDRV_CARDS (which is defined in sound/driver.h)
> > >
> > > Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
> >
> > Right now I have another (bigger) change for this include path, so
> > this patch won't be needed any more.
> >
> > I applied the patches to sound/* except for this one and
> > sound/memory.c. Thanks!
> >
> Is there anything wrong with patch for rawmidi [1]?
Ah, sorry, forgot to mention it.
I'm still considering whether it's the best way. The changes look
exaggerated just for fixing sparse warnings.
Takashi
>
> Marcin
>
> [1] http://lkml.org/lkml/2007/12/8/164
>
next prev parent reply other threads:[~2007-12-17 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-08 20:50 [PATCH] sound/core.h: include sound/driver.h Marcin Ślusarz
2007-12-14 11:02 ` Takashi Iwai
2007-12-16 1:58 ` Marcin Slusarz
2007-12-17 9:30 ` Takashi Iwai [this message]
2007-12-19 18:26 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsl211xeu.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox