From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750757AbWFFKZ5 (ORCPT ); Tue, 6 Jun 2006 06:25:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750771AbWFFKZ5 (ORCPT ); Tue, 6 Jun 2006 06:25:57 -0400 Received: from cantor.suse.de ([195.135.220.2]:33707 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1750757AbWFFKZ4 (ORCPT ); Tue, 6 Jun 2006 06:25:56 -0400 Date: Tue, 06 Jun 2006 12:25:42 +0200 Message-ID: From: Takashi Iwai To: Adrian McMenamin Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Paul Mundt , Lee Revell , linux-sh Subject: Re: [Alsa-devel] [linuxsh-dev] [PATCH] Add support for Yamaha AICA sound on SEGA Dreamcast In-Reply-To: <1149334788.9065.5.camel@localhost.localdomain> References: <1149201071.9032.13.camel@localhost.localdomain> <1149334788.9065.5.camel@localhost.localdomain> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 03 Jun 2006 12:39:48 +0100, Adrian McMenamin wrote: > > On Thu, 2006-06-01 at 23:31 +0100, Adrian McMenamin wrote: > > This adds sound for the Yamaha AICA "Super Intelligent Sound > > Processor" (PCM) device on the SEGA Dreamcast > > > > Signed off by Adrian McMenamin > > > I've had no comments back on this - I am thinking of committing to the > linux-sh cvs, though it really belongs in ALSA. Sorry for the delay. I've had a long weekend. > Any reason why I shouldn't? As Paul already pointed, the platform_device things must be fixed. Also, better to clean up the code directly accessing hardcoded addresses. Another big concern is that spu_dma_work is initialized/rewritten dynamically in spu_begin_dma() and aica_period_elapsed() via INIT_WORK() and PREPARE_WOR(). This looks pretty strange and may be racy. Takashi