From: Takashi Iwai <tiwai@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Martin Josefsson <gandalf@wlug.westbo.se>,
torvalds@osdl.org, linux-kernel@vger.kernel.org,
Joshua Kwan <joshk@triplehelix.org>,
alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] Fix ALSA resume
Date: Mon, 06 Dec 2004 15:22:03 +0100 [thread overview]
Message-ID: <s5hsm6j1p84.wl@alsa2.suse.de> (raw)
In-Reply-To: <20041204172855.350100d0.akpm@osdl.org>
At Sat, 4 Dec 2004 17:28:55 -0800,
Andrew Morton wrote:
>
> But Joshua crosses his heart and swears that the pci_disable_device() is
> also needed for a successful swsusp resume.
Yes. This would make suspend safer.
The linux-sound bk tree already includes the fix above and the patches
to add pci_disable_device() in appropriate places.
Andrew, could you update bk-alsa patch set?
> Should snd_card_pci_suspend() be doing the pci_disable_device() as well, or
> it that a responsibility of the driver which called snd_card_pci_suspend()?
So far, we suppose that the lowlevel suspend() callback should call
pci_disable_device() although we can move it to the common place,
snd_card_pci_suspend().
Takashi
prev parent reply other threads:[~2004-12-06 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-04 21:23 [PATCH] Fix ALSA resume Martin Josefsson
2004-12-04 21:54 ` Lee Revell
2004-12-05 1:28 ` Andrew Morton
2004-12-05 3:39 ` Joshua Kwan
2004-12-05 7:51 ` Andrew Morton
2004-12-05 10:06 ` Joshua Kwan
2004-12-05 12:11 ` Martin Josefsson
2004-12-06 14:22 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsm6j1p84.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=akpm@osdl.org \
--cc=alsa-devel@lists.sourceforge.net \
--cc=gandalf@wlug.westbo.se \
--cc=joshk@triplehelix.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox