From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261263AbUK2OWq (ORCPT ); Mon, 29 Nov 2004 09:22:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261375AbUK2OWq (ORCPT ); Mon, 29 Nov 2004 09:22:46 -0500 Received: from mail.suse.de ([195.135.220.2]:47754 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S261263AbUK2OWl (ORCPT ); Mon, 29 Nov 2004 09:22:41 -0500 Date: Mon, 29 Nov 2004 15:22:41 +0100 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] [2.6 patch] ALSA: remove unused functions (fwd) In-Reply-To: <20041129022935.GP4390@stusta.de> References: <20041129022935.GP4390@stusta.de> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 29 Nov 2004 03:29:35 +0100, Adrian Bunk wrote: > > > The patch forwarded below still applies and compiles against > 2.6.10-rc2-mm3. > > Please apply or comment on it. Well, I don't think that it will bring much gain to remove such small inline functions... Just my feeling, no particular objection, though. Takashi > > > ----- Forwarded message from Adrian Bunk ----- > > Date: Fri, 29 Oct 2004 02:14:04 +0200 > From: Adrian Bunk > To: perex@suse.cz > Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org > Subject: [2.6 patch] ALSA: remove unused functions > > [ this time without the problems due to a digital signature... ] > > The patch below removes two unused ALSA functions. > > > diffstat output: > sound/pci/cmipci.c | 7 +------ > sound/pci/ymfpci/ymfpci_main.c | 5 ----- > 2 files changed, 1 insertion(+), 11 deletions(-) > > > Signed-off-by: Adrian Bunk > > --- linux-2.6.10-rc1-mm1-full/sound/pci/cmipci.c.old 2004-10-28 23:48:17.000000000 +0200 > +++ linux-2.6.10-rc1-mm1-full/sound/pci/cmipci.c 2004-10-28 23:48:38.000000000 +0200 > @@ -499,17 +499,12 @@ > return inw(cm->iobase + cmd); > } > > -/* read/write operations for byte register */ > +/* write operations for byte register */ > inline static void snd_cmipci_write_b(cmipci_t *cm, unsigned int cmd, unsigned char data) > { > outb(data, cm->iobase + cmd); > } > > -inline static unsigned char snd_cmipci_read_b(cmipci_t *cm, unsigned int cmd) > -{ > - return inb(cm->iobase + cmd); > -} > - > /* bit operations for dword register */ > static void snd_cmipci_set_bit(cmipci_t *cm, unsigned int cmd, unsigned int flag) > { > --- linux-2.6.10-rc1-mm1-full/sound/pci/ymfpci/ymfpci_main.c.old 2004-10-28 23:49:00.000000000 +0200 > +++ linux-2.6.10-rc1-mm1-full/sound/pci/ymfpci/ymfpci_main.c 2004-10-28 23:49:11.000000000 +0200 > @@ -52,11 +52,6 @@ > > static void snd_ymfpci_irq_wait(ymfpci_t *chip); > > -static inline u8 snd_ymfpci_readb(ymfpci_t *chip, u32 offset) > -{ > - return readb(chip->reg_area_virt + offset); > -} > - > static inline void snd_ymfpci_writeb(ymfpci_t *chip, u32 offset, u8 val) > { > writeb(val, chip->reg_area_virt + offset); > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > ----- End forwarded message ----- > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://productguide.itmanagersjournal.com/ > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/alsa-devel >