From: Takashi Iwai <tiwai@suse.de>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] ALSA: Remove subsystem-specific malloc (0/8)
Date: Wed, 09 Jun 2004 11:03:12 +0200 [thread overview]
Message-ID: <s5hsmd514tr.wl@alsa2.suse.de> (raw)
In-Reply-To: <s5hu0xl152u.wl@alsa2.suse.de>
At Wed, 09 Jun 2004 10:57:45 +0200,
I wrote:
>
> At Wed, 9 Jun 2004 00:24:53 +0300,
> Pekka J Enberg wrote:
> >
> > This patch introduces a kcalloc() and replaces ALSA magic allocator
> > snd_kcalloc() and snd_magic_kcalloc() with it. I also fixed a memory
> > leak in the arm sa11xx driver and added a BUG() in seq_oss_synth to
> > catch failing allocations.
> >
> > I kept the snd_magic_cast macro in place just in case someone wants to
> > add a generic type checking facility in the kernel and convert the users
> > to use it.
> >
> > The patch is against 2.6.6 and was compile-tested with allyesconfig.
>
> no, this patch breaks when CONFIG_SND_DEBUG=y. the compile is ok but
> it won't work, as long as you leave snd_magic_cast.
sorry, i overlooked the patch 8/8.
but i don't see no reason to leave only snd_magic_cast.
if there is no cast checking facility, we should remove them all.
Takashi
prev parent reply other threads:[~2004-06-09 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 21:24 [RFC][PATCH] ALSA: Remove subsystem-specific malloc (0/8) Pekka J Enberg
2004-06-09 6:20 ` Arjan van de Ven
2004-06-09 7:08 ` Jaroslav Kysela
2004-06-09 8:57 ` Takashi Iwai
2004-06-09 9:03 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsmd514tr.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox