From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1BE4C433E0 for ; Sun, 17 Jan 2021 07:59:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D60F22583 for ; Sun, 17 Jan 2021 07:59:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727880AbhAQH6o (ORCPT ); Sun, 17 Jan 2021 02:58:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:39672 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbhAQH6f (ORCPT ); Sun, 17 Jan 2021 02:58:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 32347AC4F; Sun, 17 Jan 2021 07:57:54 +0000 (UTC) Date: Sun, 17 Jan 2021 08:57:53 +0100 Message-ID: From: Takashi Iwai To: Nicolas Saenz Julienne Cc: mripard@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, eric@anholt.net, daniel@ffwll.ch, airlied@linux.ie, stefan.wahren@i2se.com, broonie@kernel.org, tiwai@suse.com Subject: Re: [PATCH] drm/vc4: Unify PCM card's driver_name In-Reply-To: <20210115191209.12852-1-nsaenzjulienne@suse.de> References: <20210115191209.12852-1-nsaenzjulienne@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Jan 2021 20:12:09 +0100, Nicolas Saenz Julienne wrote: > > User-space ALSA matches a card's driver name against an internal list of > aliases in order to select the correct configuration for the system. > When the driver name isn't defined, the match is performed against the > card's name. > > With the introduction of RPi4 we now have two HDMI ports with two > distinct audio cards. This is reflected in their names, making them > different from previous RPi versions. With this, ALSA ultimately misses > the board's configuration on RPi4. > > In order to avoid this, set "card->driver_name" to "vc4-hdmi" > unanimously. > > Signed-off-by: Nicolas Saenz Julienne > Fixes: f437bc1ec731 ("drm/vc4: drv: Support BCM2711") Looks good to me. Reviewed-by: Takashi Iwai thanks, Takashi > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index 97f368bc1c67..4bdc8e71b5e5 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -1404,6 +1404,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi) > card->dai_link = dai_link; > card->num_links = 1; > card->name = vc4_hdmi->variant->card_name; > + card->driver_name = "vc4-hdmi"; > card->dev = dev; > card->owner = THIS_MODULE; > > -- > 2.29.2 >