From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21494C2D0DA for ; Thu, 26 Dec 2019 15:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4529206A4 for ; Thu, 26 Dec 2019 15:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbfLZPpG (ORCPT ); Thu, 26 Dec 2019 10:45:06 -0500 Received: from mx2.suse.de ([195.135.220.15]:41772 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbfLZPpF (ORCPT ); Thu, 26 Dec 2019 10:45:05 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 425ACAFA8; Thu, 26 Dec 2019 15:45:03 +0000 (UTC) Date: Thu, 26 Dec 2019 16:45:02 +0100 Message-ID: From: Takashi Iwai To: Paul Menzel Cc: Jaroslav Kysela , Takashi Sakamoto , Takashi Iwai , alsa-devel@alsa-project.org, LKML , dri-devel@lists.freedesktop.org Subject: Re: [Regression drm-tip] Internal audio device missing In-Reply-To: <91e1ebe8-270e-d62f-844e-2018fe77145e@molgen.mpg.de> References: <6aa4e167-abb0-6a2c-c00e-558aa79d94be@molgen.mpg.de> <91e1ebe8-270e-d62f-844e-2018fe77145e@molgen.mpg.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Dec 2019 15:41:34 +0100, Paul Menzel wrote: > > Dear Takashi, > > > Am 26.12.19 um 11:03 schrieb Takashi Iwai: > > On Thu, 26 Dec 2019 10:47:18 +0100, Paul Menzel wrote: > > >> With > >> > >> $ git describe --tags drm-tip/drm-tip > >> v5.5-rc3-1481-ga20d8cd6901a > >> > >> the internal audio device is not available, and just a dummy device. > >> > >> Running `alsa-info.sh` [1], the messages below are shown with the > >> problematic Linux kernel. > >> > >> alsactl: get_controls:567: snd_ctl_open error: Sound protocol is > >> not compatible > >> cat: /tmp/alsa-info.ateDlDjrZX/alsactl.tmp: No such file or directory > > > > That's an unexpected side-effect of the recent protocol version bump > > in sound.git for-next branch. It seems that we can't change the minor > > version unless we really want to break something. > > > > Below is the fix patch. Please give it a try. > > Thank you for the quick reply and fix. > > > -- 8< -- > > From: Takashi Iwai > > Subject: [PATCH] ALSA: control: Fix incompatible protocol error > > > > The recent change to bump the ALSA control API protocol version from > > 2.0.7 to 2.1.0 caused a regression on user-space; while the user-space > > expects both the major and the minor versions to be identical with the > > supported numbers, we changed the minor number from 0 to 1. > > > > For recovering from the incompatibility, this patch changes the > > protocol version again to 2.0.8, which is compatible, but yet higher > > than the original number 2.0.7, indicating that the protocol change. > > > > Fixes: bd3eb4e87eb3 ("ALSA: ctl: bump protocol version up to v2.1.0") > > Reported-by: Paul Menzel > > Signed-off-by: Takashi Iwai > > --- > > include/uapi/sound/asound.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h > > index e36dadaf84ba..30ebb2a42983 100644 > > --- a/include/uapi/sound/asound.h > > +++ b/include/uapi/sound/asound.h > > @@ -936,7 +936,7 @@ struct snd_timer_tread { > > * * > > ****************************************************************************/ > > -#define SNDRV_CTL_VERSION SNDRV_PROTOCOL_VERSION(2, 1, > > 0) > > +#define SNDRV_CTL_VERSION SNDRV_PROTOCOL_VERSION(2, 0, 8) > > struct snd_ctl_card_info { > > int card; /* card number */ > > > > Tested-by: Paul Menzel > > Are there CI systems, which should have caught this problem? > > Which user-space component should forward this problem to the user > (desktop environment displaying a warning)? Unfortunately no -- I'd love to have it, though. I usually test and push more carefully, but it was a bit rush before the holidays :) Now merged and pushed out. thanks, Takashi