From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B515C04AAF for ; Mon, 20 May 2019 09:56:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF3BA206B6 for ; Mon, 20 May 2019 09:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730599AbfETJ4I (ORCPT ); Mon, 20 May 2019 05:56:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:45426 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725951AbfETJ4I (ORCPT ); Mon, 20 May 2019 05:56:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 88F67AFA5; Mon, 20 May 2019 09:56:07 +0000 (UTC) Date: Mon, 20 May 2019 11:56:07 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: Luis Chamberlain , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] firmware: Add support for loading compressed files In-Reply-To: <20190520093929.GB15326@kroah.com> References: <20190520092647.8622-1-tiwai@suse.de> <20190520093929.GB15326@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 May 2019 11:39:29 +0200, Greg Kroah-Hartman wrote: > > On Mon, May 20, 2019 at 11:26:42AM +0200, Takashi Iwai wrote: > > Hi, > > > > this is a patch set to add the support for loading compressed firmware > > files. > > > > The primary motivation is to reduce the storage size; e.g. currently > > the amount of /lib/firmware on my machine counts up to 419MB, and this > > can be reduced to 130MB file compression. No bad deal. > > > > The feature adds only fallback to the compressed file, so it should > > work as it was as long as the normal firmware file is present. The > > f/w loader decompresses the content, so that there is no change needed > > in the caller side. > > > > Currently only XZ format is supported. A caveat is that the kernel XZ > > helper code supports only CRC32 (or none) integrity check type, so > > you'll have to compress the files via xz -C crc32 option. > > > > The patch set begins with a few other improvements and refactoring, > > followed by the compression support. > > > > In addition to this, dracut needs a small fix to deal with the *.xz > > files. > > > > Also, the latest patchset is found in topic/fw-decompress branch of my > > sound.git tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > > After a quick review, these all look good to me, nice job. > > One recommendation, can we add support for testing this to the > tools/testing/selftests/firmware/ tests? And you did run those > regression tests to verify that you didn't get any of the config options > messed up, right? :) Oh, do you believe I'm a so modern person who lets computer working on everything? ;) I only tested manually, so far, this will be my homework today. Thanks for pointing to it! Takashi