public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Mark Brown" <broonie@kernel.org>
Cc: "Ryan Lee" <ryans.lee@maximintegrated.com>,
	<alsa-devel@alsa-project.org>, <lgirdwood@gmail.com>,
	<ryan.lee.maxim@gmail.com>, <perex@perex.cz>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style
Date: Wed, 10 Jan 2018 11:21:56 +0100	[thread overview]
Message-ID: <s5htvvuxbcr.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180110101506.GC9003@sirena.org.uk>

On Wed, 10 Jan 2018 11:15:06 +0100,
Mark Brown wrote:
> 
> On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote:
> 
> > @@ -1,4 +1,4 @@
> > -/* SPDX-License-Identifier: GPL-2.0 */
> > +// SPDX-License-Identifier: GPL-2.0
> >  /* Copyright (c) 2017, Maxim Integrated */
> 
> Please change the entire header to C++, mixing C and C++ on adjacent
> lines looks ugly.

I'm not sure whether it's a good direction to go, either.

I rather wonder why SPDX line *must* be in C++ comment style...


thanks,

Takashi

  reply	other threads:[~2018-01-10 10:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10  5:01 [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style Ryan Lee
2018-01-10  5:01 ` [PATCH 2/4] ASoC: max98373: Added missing blank lines Ryan Lee
2018-01-10 11:13   ` Applied "ASoC: max98373: Added missing blank lines" to the asoc tree Mark Brown
2018-01-10  5:02 ` [PATCH 3/4] ASoC: max98373: Added TDM off if parameters are all zeroes Ryan Lee
2018-01-10 11:13   ` Applied "ASoC: max98373: Added TDM off if parameters are all zeroes" to the asoc tree Mark Brown
2018-01-10  5:02 ` [PATCH 4/4] ASoC: max98373: Modified control names for TLV controls Ryan Lee
2018-01-10 11:13   ` Applied "ASoC: max98373: Modified control names for TLV controls" to the asoc tree Mark Brown
2018-01-10 10:15 ` [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style Mark Brown
2018-01-10 10:21   ` Takashi Iwai [this message]
2018-01-10 10:29     ` Mark Brown
2018-01-18 21:35       ` Ryan Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htvvuxbcr.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=ryan.lee.maxim@gmail.com \
    --cc=ryans.lee@maximintegrated.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox