From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbbKZIXt (ORCPT ); Thu, 26 Nov 2015 03:23:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:43901 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbbKZIXq (ORCPT ); Thu, 26 Nov 2015 03:23:46 -0500 Date: Thu, 26 Nov 2015 09:23:44 +0100 Message-ID: From: Takashi Iwai To: "Sudip Mukherjee" Cc: "Mark Brown" , "Jaroslav Kysela" , , Subject: Re: [PATCH v2] ASoC: hdac_hdmi: convert num_nodes to int In-Reply-To: <1448525299-7011-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1448525299-7011-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Nov 2015 09:08:19 +0100, Sudip Mukherjee wrote: > > All uses of num_nodes are considering it as a signed integer and that is > very much clear when we try to save the error value in it and later try > to compare it with less than 0. No. The point is that the value checked *there* has to be int, not the value used for the success case. Just have a temporary value, e.g. int num_nodes, assign there, check it, then assign the value to codec->num_nodes field. The num_nodes field itself is obviously an unsigned. Takashi > > Signed-off-by: Sudip Mukherjee > --- > include/sound/hdaudio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h > index e2b712c..c5fad14 100644 > --- a/include/sound/hdaudio.h > +++ b/include/sound/hdaudio.h > @@ -71,7 +71,7 @@ struct hdac_device { > unsigned int flags, unsigned int *res); > > /* widgets */ > - unsigned int num_nodes; > + int num_nodes; > hda_nid_t start_nid, end_nid; > > /* misc flags */ > -- > 1.9.1 > >