From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752221AbbAOILy (ORCPT ); Thu, 15 Jan 2015 03:11:54 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45016 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbbAOILx (ORCPT ); Thu, 15 Jan 2015 03:11:53 -0500 Date: Thu, 15 Jan 2015 09:11:51 +0100 Message-ID: From: Takashi Iwai To: Davidlohr Bueso Cc: Andrew Veliath , Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound/oss: use current->state helpers In-Reply-To: <1421308290.17403.4.camel@stgolabs.net> References: <1421305903.17403.0.camel@stgolabs.net> <1421308290.17403.4.camel@stgolabs.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 14 Jan 2015 23:51:30 -0800, Davidlohr Bueso wrote: > > On Thu, 2015-01-15 at 08:33 +0100, Takashi Iwai wrote: > > At Wed, 14 Jan 2015 23:11:43 -0800, > > Davidlohr Bueso wrote: > > > > > > From: Davidlohr Bueso > > > > > > Call __set_current_state() instead of assigning the new state directly. > > > These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping > > > track of who changed the state. > > > > > > Signed-off-by: Davidlohr Bueso > > > > The author and sign-off have different addresses. Could you align? > > I don't see a problem with that. All my patches are the same. Well, it's a bit unusual. Why do they need to differ? Is the author another Davidlohr? :) If this form is preferred, I'm willing to apply, but I just wonder... Takashi