public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Chen Gang <gang.chen@sunrus.com.cn>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	alsa-devel@alsa-project.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: soc: soc-pcm: Remove useless varialbe 'i'
Date: Sat, 03 Jan 2015 10:59:29 +0100	[thread overview]
Message-ID: <s5htx08dw1q.wl-tiwai@suse.de> (raw)
In-Reply-To: <54A7BA55.3020607@sunrus.com.cn>

At Sat, 03 Jan 2015 17:45:57 +0800,
Chen Gang wrote:
> 
> 'i' is useless in soc_pcm_set_msb(), so remove it, the related warning
> (with allmodconfig under s390):
> 
>     CC [M]  sound/soc/soc-pcm.o
>   sound/soc/soc-pcm.c: In function 'soc_pcm_set_msb':
>   sound/soc/soc-pcm.c:307:11: warning: unused variable 'i' [-Wunused-variable]
>     int ret, i;
>              ^

Thanks, but this was already fixed.


Takashi

> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  sound/soc/soc-pcm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index d6e8d6b..6b0136e 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -304,7 +304,7 @@ static bool soc_pcm_has_symmetry(struct snd_pcm_substream *substream)
>  static void soc_pcm_set_msb(struct snd_pcm_substream *substream, int bits)
>  {
>  	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> -	int ret, i;
> +	int ret;
>  
>  	if (!bits)
>  		return;
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2015-01-03  9:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-03  9:45 [PATCH] sound: soc: soc-pcm: Remove useless varialbe 'i' Chen Gang
2015-01-03  9:59 ` Takashi Iwai [this message]
2015-01-03 10:15   ` Chen Gang S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htx08dw1q.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gang.chen@sunrus.com.cn \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox