From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754005Ab1JRIq7 (ORCPT ); Tue, 18 Oct 2011 04:46:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53732 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490Ab1JRIq6 (ORCPT ); Tue, 18 Oct 2011 04:46:58 -0400 Date: Tue, 18 Oct 2011 10:46:55 +0200 Message-ID: From: Takashi Iwai To: =?UTF-8?B?w4lyaWM=?= Piel Cc: "Rafael J. Wysocki" , alsa-devel@alsa-project.org, david.henningsson@canonical.com, Linux Kernel Mailing List Subject: Re: [REGRESSION] Sound goes too fast due to 798cb7e897210 In-Reply-To: <4E9D3AEE.6070809@tremplin-utc.net> References: <4E9D3466.5000901@tremplin-utc.net> <4E9D3AEE.6070809@tremplin-utc.net> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 18 Oct 2011 10:38:06 +0200, Éric Piel wrote: > > Op 18-10-11 10:23, Takashi Iwai schreef: > > At Tue, 18 Oct 2011 10:10:14 +0200, > > Éric Piel wrote: > : > > If that commit affects, the best fix would be to give a quirk specific > > to your device. Try to pass either position_fix=1 or position_fix=2. > > Only one of them should work (likely 2). > > > > After checking it, you can add it to position_fix_list[] in > > sound/pci/hda/hda_intel.c together with PCI SSID. > > Hello, > Thanks for the quick response. Indeed forcing position_fix=1 does fix > the bug. I'll not try to make a patch for my device. Hm, interesting. So, in your case, the position-buffer exists and reports some valid values, but the values are sloppy actually. It's hard to detect in the driver, unfortunately. The relevant commit (and its original fix) were the attempts to detect better, but it seems that it fails... FWIW, the patch below is what I'm committing to the tree. thanks, Takashi --- From: Takashi Iwai Subject: [PATCH] ALSA: hda - Add position_fix quirk for Dell Inspiron 1010 The previous fix for the position-buffer check gives yet another regression on a Dell laptop. The safest fix right now is to add a static quirk for this device (and better to apply it for stable kernels too). Reported-by: Éric Piel Cc: Signed-off-by: Takashi Iwai --- sound/pci/hda/hda_intel.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index e9a2a87..191284a 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2370,6 +2370,7 @@ static int azx_dev_free(struct snd_device *device) static struct snd_pci_quirk position_fix_list[] __devinitdata = { SND_PCI_QUIRK(0x1028, 0x01cc, "Dell D820", POS_FIX_LPIB), SND_PCI_QUIRK(0x1028, 0x01de, "Dell Precision 390", POS_FIX_LPIB), + SND_PCI_QUIRK(0x1028, 0x02c6, "Dell Inspiron 1010", POS_FIX_LPIB), SND_PCI_QUIRK(0x103c, 0x306d, "HP dv3", POS_FIX_LPIB), SND_PCI_QUIRK(0x1043, 0x813d, "ASUS P5AD2", POS_FIX_LPIB), SND_PCI_QUIRK(0x1043, 0x81b3, "ASUS", POS_FIX_LPIB), -- 1.7.7