From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753731Ab1FMHqd (ORCPT ); Mon, 13 Jun 2011 03:46:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48724 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753348Ab1FMHqc (ORCPT ); Mon, 13 Jun 2011 03:46:32 -0400 Date: Mon, 13 Jun 2011 09:46:31 +0200 Message-ID: From: Takashi Iwai To: Joe Perches Cc: Borislav Petkov , Linus Torvalds , Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: Fix beep_device compilation warnings In-Reply-To: <1307908963.29640.4.camel@Joe-Laptop> References: <20110612155021.GA30023@liondog.tnic> <20110612194037.GA26274@liondog.tnic> <1307908963.29640.4.camel@Joe-Laptop> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 12 Jun 2011 13:02:43 -0700, Joe Perches wrote: > > Using static inline functions can reduce compilation messages > and macro misuse. > > Signed-off-by: Joe Perches > > --- > > Maybe this helps? > > On Sun, 2011-06-12 at 21:40 +0200, Borislav Petkov wrote: > > Btw, I keep noticing those when building on 32bit: > > sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5045’: > > sound/pci/hda/patch_conexant.c:1232:3: warning: statement with no effect > > sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5051’: > > sound/pci/hda/patch_conexant.c:2067:3: warning: statement with no effect > > sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5066’: > > sound/pci/hda/patch_conexant.c:3261:3: warning: statement with no effect > > sound/pci/hda/patch_conexant.c: In function ‘patch_conexant_auto’: > > sound/pci/hda/patch_conexant.c:4370:3: warning: statement with no effect Yep, this must be. Now applied. Thanks! Takashi > > sound/pci/hda/hda_beep.h | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/hda/hda_beep.h b/sound/pci/hda/hda_beep.h > index f1de1ba..4967eab 100644 > --- a/sound/pci/hda/hda_beep.h > +++ b/sound/pci/hda/hda_beep.h > @@ -50,7 +50,12 @@ int snd_hda_enable_beep_device(struct hda_codec *codec, int enable); > int snd_hda_attach_beep_device(struct hda_codec *codec, int nid); > void snd_hda_detach_beep_device(struct hda_codec *codec); > #else > -#define snd_hda_attach_beep_device(...) 0 > -#define snd_hda_detach_beep_device(...) > +static inline int snd_hda_attach_beep_device(struct hda_codec *codec, int nid) > +{ > + return 0; > +} > +void snd_hda_detach_beep_device(struct hda_codec *codec) > +{ > +} > #endif > #endif > >